Stabilize integration tests: fix flaky heartbeat test#417
Draft
dkropachev wants to merge 1 commit intomasterfrom
Draft
Stabilize integration tests: fix flaky heartbeat test#417dkropachev wants to merge 1 commit intomasterfrom
dkropachev wants to merge 1 commit intomasterfrom
Conversation
Replace flaky connection-count assertion in test_heartbeat.cpp with direct heartbeat timeout log check. The original test's total_connections metric could fluctuate due to reconnection attempts, and execute_async calls could interfere with idle-connection heartbeat detection.
dkropachev
changed the title
dkropachev
force-pushed
the
dk/stabilize-integration-tests
branch
from
1db29af to
11c4bda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
total_connectionsmetric could fluctuate due to reconnection attempts, andexecute_asynccalls could interfere with idle-connection heartbeat detection.Pre-review checklist
Makefilein{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.